Messages in this thread | | | Date | Sat, 8 Feb 2020 15:01:52 +0100 | From | Marco Felsch <> | Subject | Re: [PATCH] watchdog: da9062: Add dependency on I2C |
| |
Hi,
On 20-02-08 05:08, Guenter Roeck wrote: > Since commit 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic > safe"), the driver calls i2c functions directly. It now therefore depends > on I2C. This is a hard dependency which overrides COMPILE_TEST.
I just wondered why it doesn't complain if no regmap support is on and surprise it provides stubs ^^ Is it worth to add i2c stubs too?
Regards, Marco
> Reported-by: kbuild test robot <lkp@intel.com> > Fixes: 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe") > Cc: Marco Felsch <m.felsch@pengutronix.de> > Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > Cc: Stefan Lengfeld <contact@stefanchrist.eu> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index c3c8e0786a99..9ea2b43d4b01 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -207,6 +207,7 @@ config DA9063_WATCHDOG > config DA9062_WATCHDOG > tristate "Dialog DA9062/61 Watchdog" > depends on MFD_DA9062 || COMPILE_TEST > + depends on I2C > select WATCHDOG_CORE > help > Support for the watchdog in the DA9062 and DA9061 PMICs. > -- > 2.17.1 > >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |