Messages in this thread | | | Date | Sat, 08 Feb 2020 20:36:50 +0000 | From | Nícolas F. R. A. Prado <> | Subject | Re: [PATCH 1/3] media: vimc: Support multiple buscodes for each pixelformat |
| |
Hi Helen, thanks for the review.
Just one comment below.
On Wed, Feb 05, 2020 at 11:17:31AM -0300, Helen Koike wrote: > > Hi Nícolas, > > Thanks for the patch, just some minor nits: > > On 2/2/20 1:50 PM, Nícolas F. R. A. Prado wrote: > > diff --git a/drivers/media/platform/vimc/vimc-common.h b/drivers/media/platform/vimc/vimc-common.h > > index 87eb8259c2a8..132a5889f1ea 100644 > > --- a/drivers/media/platform/vimc/vimc-common.h > > +++ b/drivers/media/platform/vimc/vimc-common.h > > @@ -69,7 +69,7 @@ do { \ > > * V4L2_PIX_FMT_* fourcc pixelformat and its bytes per pixel (bpp) > > */ > > struct vimc_pix_map { > > - unsigned int code; > > + unsigned int code[3]; > > why 3?
On my patch I'm using at most 2. I chose 3 so that it would be easier to add more formats, but I guess it doesn't really make sense, since it's wasting memory and that value can be increased when it's necessary. So I should change it to 2, right?
> Regards, > Helen
Thanks, Nícolas
| |