lkml.org 
[lkml]   [2020]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 108/148] scsi: qla4xxx: fix double free bug
    3.16.82-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>

    commit 3fe3d2428b62822b7b030577cd612790bdd8c941 upstream.

    The variable init_fw_cb is released twice, resulting in a double free
    bug. The call to the function dma_free_coherent() before goto is removed to
    get rid of potential double free.

    Fixes: 2a49a78ed3c8 ("[SCSI] qla4xxx: added IPv6 support.")
    Link: https://lore.kernel.org/r/1572945927-27796-1-git-send-email-bianpan2016@163.com
    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Acked-by: Manish Rangankar <mrangankar@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/qla4xxx/ql4_mbx.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/scsi/qla4xxx/ql4_mbx.c
    +++ b/drivers/scsi/qla4xxx/ql4_mbx.c
    @@ -641,9 +641,6 @@ int qla4xxx_initialize_fw_cb(struct scsi

    if (qla4xxx_get_ifcb(ha, &mbox_cmd[0], &mbox_sts[0], init_fw_cb_dma) !=
    QLA_SUCCESS) {
    - dma_free_coherent(&ha->pdev->dev,
    - sizeof(struct addr_ctrl_blk),
    - init_fw_cb, init_fw_cb_dma);
    goto exit_init_fw_cb;
    }

    \
     
     \ /
      Last update: 2020-02-08 19:35    [W:3.570 / U:1.944 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site