lkml.org 
[lkml]   [2020]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] random: add rng-seed= command line option
On Fri, 7 Feb 2020 09:28:27 -0800
Kees Cook <keescook@chromium.org> wrote:

> > static void __init setup_command_line(char *command_line)
> > {
> > size_t len, xlen = 0, ilen = 0;
> > + static const char argsep_str[] __initconst = " -- ";
> > + static const char alloc_fail_msg[] __initconst =
> > + "%s: Failed to allocate %zu bytes\n";
>
> There's some refactoring in this patch unrelated to the seed logic. Can
> you split that out? (I think these changes are good.)
>
> >
> > if (extra_command_line)
> > xlen = strlen(extra_command_line);
>
> Unrelated note: whoa this is based on linux-next which has a massive
> change to the boot command line handling and appears to be doing some
> bad things. I need to go find that thread...

This would be Masami's bootconfig work which Linus already pulled in.
What bad things are there? You can see the thread here:

http://lore.kernel.org/r/157867220019.17873.13377985653744804396.stgit@devnote2
http://lore.kernel.org/r/CAHk-=wjfjO+h6bQzrTf=YCZA53Y3EDyAs3Z4gEsT7icA3u_Psw@mail.gmail.com

-- Steve

\
 
 \ /
  Last update: 2020-02-07 18:48    [W:0.340 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site