Messages in this thread | | | Date | Fri, 07 Feb 2020 11:16:48 +0100 (CET) | Subject | Re: [PATCH net] net: ethernet: ave: Add capability of rgmii-id mode | From | David Miller <> |
| |
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Date: Thu, 6 Feb 2020 10:59:36 +0900
> This allows you to specify the type of rgmii-id that will enable phy > internal delay in ethernet phy-mode. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
I do not understand this change at all.
At a minimum you must explain things more clearly and completely in your commit message.
Are you just adding all of the RGMII cases to the code that only currently mentions PHY_INTERFACE_MODE_RGMII? If so, why did you only do this for some but not all of the get_pinmode() methods in this driver?
Thank you.
| |