lkml.org 
[lkml]   [2020]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH liburing v2 0/1] test: add epoll test case
From
Date
On 2/6/20 10:33 AM, Stefano Garzarella wrote:
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 77f22c3da30f..2769451af89a 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6301,7 +6301,7 @@ static __poll_t io_uring_poll(struct file *file, poll_table *wait)
> if (READ_ONCE(ctx->rings->sq.tail) - ctx->cached_sq_head !=
> ctx->rings->sq_ring_entries)
> mask |= EPOLLOUT | EPOLLWRNORM;
> - if (READ_ONCE(ctx->rings->cq.head) != ctx->cached_cq_tail)
> + if (!io_cqring_events(ctx, false))
> mask |= EPOLLIN | EPOLLRDNORM;
>
> return mask;

Are you going to send this as a proper patch? If so, I think you'll want
to remove the '!' negation for that check.

--
Jens Axboe

\
 
 \ /
  Last update: 2020-02-06 20:47    [W:0.069 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site