Messages in this thread | | | Subject | Re: [PATCH liburing v2 0/1] test: add epoll test case | From | Jens Axboe <> | Date | Thu, 6 Feb 2020 12:46:51 -0700 |
| |
On 2/6/20 10:33 AM, Stefano Garzarella wrote: > diff --git a/fs/io_uring.c b/fs/io_uring.c > index 77f22c3da30f..2769451af89a 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -6301,7 +6301,7 @@ static __poll_t io_uring_poll(struct file *file, poll_table *wait) > if (READ_ONCE(ctx->rings->sq.tail) - ctx->cached_sq_head != > ctx->rings->sq_ring_entries) > mask |= EPOLLOUT | EPOLLWRNORM; > - if (READ_ONCE(ctx->rings->cq.head) != ctx->cached_cq_tail) > + if (!io_cqring_events(ctx, false)) > mask |= EPOLLIN | EPOLLRDNORM; > > return mask;
Are you going to send this as a proper patch? If so, I think you'll want to remove the '!' negation for that check.
-- Jens Axboe
| |