Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 6 Feb 2020 11:32:51 -0800 | Subject | Re: [PATCH v2] genirq: Clarify that irq wake state is orthogonal to enable/disable |
| |
Hi,
On Thu, Feb 6, 2020 at 11:15 AM Stephen Boyd <swboyd@chromium.org> wrote: > > There's some confusion around if an irq that's disabled with > disable_irq() can still wake the system from sleep states such as > "suspend to RAM". Let's clarify this in the kernel documentation for > irq_set_irq_wake() so that it's clear that an irq can be disabled and > still wake the system if it has been marked for wakeup. > > Cc: Marc Zyngier <maz@kernel.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Lina Iyer <ilina@codeaurora.org> > Cc: Maulik Shah <mkshah@codeaurora.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Changes from v1: > * Added the last sentence from tglx > > kernel/irq/manage.c | 7 +++++++ > 1 file changed, 7 insertions(+)
FWIW this mathes my understanding and in the past I've done work to 'drivers/pinctrl/pinctrl-rockchip.c' making it support this exact thing. Thanks for documenting.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
| |