lkml.org 
[lkml]   [2020]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/16] bus: mhi: core: Add support for registering MHI controllers
On Fri, Jan 31, 2020 at 07:19:55PM +0530, Manivannan Sadhasivam wrote:
> +static void mhi_release_device(struct device *dev)
> +{
> + struct mhi_device *mhi_dev = to_mhi_device(dev);
> +
> + if (mhi_dev->ul_chan)
> + mhi_dev->ul_chan->mhi_dev = NULL;

That looks really odd. Why didn't you just drop the reference you
should have grabbed here for this pointer? You did properly increment
it when you saved it, right? :)

> +
> + if (mhi_dev->dl_chan)
> + mhi_dev->dl_chan->mhi_dev = NULL;

Same here.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-02-06 20:25    [W:0.116 / U:1.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site