Messages in this thread | | | Subject | Re: [PATCH][next] tracing/kprobe: Fix uninitialized variable bug | From | Tom Zanussi <> | Date | Wed, 05 Feb 2020 17:24:48 -0600 |
| |
Hi Gustavo,
On Wed, 2020-02-05 at 16:34 -0600, Gustavo A. R. Silva wrote: > There is a potential execution path in which variable *ret* is > returned > without being properly initialized, previously. > > Fix this by initializing variable *ret* to 0. >
Good catch. Thanks for fixing this!
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
> Addresses-Coverity-ID: 1491142 ("Uninitialized scalar variable") > Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation > functions") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > kernel/trace/trace_kprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_kprobe.c > b/kernel/trace/trace_kprobe.c > index d8264ebb9581..362cca52f5de 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -1012,7 +1012,7 @@ int __kprobe_event_add_fields(struct > dynevent_cmd *cmd, ...) > { > struct dynevent_arg arg; > va_list args; > - int ret; > + int ret = 0; > > if (cmd->type != DYNEVENT_TYPE_KPROBE) > return -EINVAL;
| |