| Date | Wed, 5 Feb 2020 17:28:29 -0500 | From | Peter Xu <> | Subject | Re: [PATCH v5 03/19] KVM: Don't free new memslot if allocation of said memslot fails |
| |
On Tue, Jan 21, 2020 at 02:31:41PM -0800, Sean Christopherson wrote: > The two implementations of kvm_arch_create_memslot() in x86 and PPC are > both good citizens and free up all local resources if creation fails. > Return immediately (via a superfluous goto) instead of calling > kvm_free_memslot(). > > Note, the call to kvm_free_memslot() is effectively an expensive nop in > this case as there are no resources to be freed.
(I failed to understand why that is expensive.. but the change looks OK)
> > No functional change intended. > > Acked-by: Christoffer Dall <christoffer.dall@arm.com> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
-- Peter Xu
|