Messages in this thread | | | From | Joel Fernandes <> | Date | Wed, 5 Feb 2020 08:41:55 -0800 | Subject | Re: [PATCH] Revert kheaders feature |
| |
On Wed, Feb 5, 2020 at 8:02 AM Joel Fernandes <joel@joelfernandes.org> wrote: > > On Wed, Feb 05, 2020 at 03:46:29PM +0000, Greg Kroah-Hartman wrote: > > Now that BPF does not need a copy of the kernel headers anymore in order > > to build programs, there's no real need for putting the kernel headers > > into a kernel module. So drop the feature quick, before someone starts > > using it :) > > Temporary Nack. Adding Alexei to the thread. > > I believe at the time of this going in, the BPF's BTF feature was not fully > ready or able to support the usecases. Especially because BPF programs can > call or use macros in kernel headers as well. > > Also, now BCC project does depend on this and so does bpftrace. Have both > of these tools migrated to use BTF and don't need CONFIG_KHEADERS to be > compiled? Sorry if I lost track. >
Sorry to call it CONFIG_KHEADERS, obviously I mean CONFIG_IKHEADERS.
thanks,
- Joel
| |