lkml.org 
[lkml]   [2020]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] printk: Declare log_wait as external variable
On Tue, Feb 04, 2020 at 08:22:11PM +0900, Sergey Senozhatsky wrote:
> On (20/02/04 11:05), Andy Shevchenko wrote:
> > > > --- a/kernel/printk/printk.c
> > > > +extern wait_queue_head_t log_wait; /* Used in fs/proc/kmsg.c */
> > > > DECLARE_WAIT_QUEUE_HEAD(log_wait);
> > > > +#else
> > > > +static DECLARE_WAIT_QUEUE_HEAD(log_wait);
> > > > +#endif /* CONFIG_PROC_FS */
> > >
> > > [..]
> > >
> > > Since we are now introducing CONFIG_PROC_FS dependency to printk (and
> > > proc/kmsg already has CONFIG_PRINTK dependency),
> >
> > I'm not sure I understood. The above does not introduce any dependencies.
>
> kernel/printk/printk.c
> +#ifdef CONFIG_PROC_FS
> ..
>
> Not exactly "dependency"... what is the correct word here.

Maybe "ifdeferry" ?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-02-04 12:33    [W:0.100 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site