lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 66/68] seq_tab_next() should increase position index
    Date
    From: Vasily Averin <vvs@virtuozzo.com>

    [ Upstream commit 70a87287c821e9721b62463777f55ba588ac4623 ]

    if seq_file .next fuction does not change position index,
    read after some lseek can generate unexpected output.

    https://bugzilla.kernel.org/show_bug.cgi?id=206283
    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
    index 61c55621b9589..c150521647172 100644
    --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
    +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
    @@ -66,8 +66,7 @@ static void *seq_tab_start(struct seq_file *seq, loff_t *pos)
    static void *seq_tab_next(struct seq_file *seq, void *v, loff_t *pos)
    {
    v = seq_tab_get_idx(seq->private, *pos + 1);
    - if (v)
    - ++*pos;
    + ++(*pos);
    return v;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-02-03 17:48    [W:4.116 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site