lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 14/90] reiserfs: Fix memory leak of journal device string
    Date
    From: Jan Kara <jack@suse.cz>

    commit 5474ca7da6f34fa95e82edc747d5faa19cbdfb5c upstream.

    When a filesystem is mounted with jdev mount option, we store the
    journal device name in an allocated string in superblock. However we
    fail to ever free that string. Fix it.

    Reported-by: syzbot+1c6756baf4b16b94d2a6@syzkaller.appspotmail.com
    Fixes: c3aa077648e1 ("reiserfs: Properly display mount options in /proc/mounts")
    CC: stable@vger.kernel.org
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/reiserfs/super.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/reiserfs/super.c
    +++ b/fs/reiserfs/super.c
    @@ -629,6 +629,7 @@ static void reiserfs_put_super(struct su
    reiserfs_write_unlock(s);
    mutex_destroy(&REISERFS_SB(s)->lock);
    destroy_workqueue(REISERFS_SB(s)->commit_wq);
    + kfree(REISERFS_SB(s)->s_jdev);
    kfree(s->s_fs_info);
    s->s_fs_info = NULL;
    }
    @@ -2240,6 +2241,7 @@ error_unlocked:
    kfree(qf_names[j]);
    }
    #endif
    + kfree(sbi->s_jdev);
    kfree(sbi);

    s->s_fs_info = NULL;

    \
     
     \ /
      Last update: 2020-02-03 17:37    [W:4.144 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site