Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v5 3/7] console: Use for_each_console() helper in unregister_console() | Date | Mon, 3 Feb 2020 15:31:26 +0200 |
| |
We have rather open coded single linked list manipulations where we may simple use for_each_console() helper with properly set exit conditions.
Replace open coded single-linked list handling with for_each_console() helper in use.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Mladek <pmladek@suse.com> --- v5: no change
kernel/printk/printk.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 21b1a5d5e5b0..c63338df76cf 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2816,7 +2816,7 @@ EXPORT_SYMBOL(register_console); int unregister_console(struct console *console) { - struct console *a, *b; + struct console *con; int res; pr_info("%sconsole [%s%d] disabled\n", @@ -2832,11 +2832,10 @@ int unregister_console(struct console *console) if (console_drivers == console) { console_drivers=console->next; res = 0; - } else if (console_drivers) { - for (a=console_drivers->next, b=console_drivers ; - a; b=a, a=b->next) { - if (a == console) { - b->next = a->next; + } else { + for_each_console(con) { + if (con->next == console) { + con->next = console->next; res = 0; break; } -- 2.24.1
| |