Messages in this thread | | | Subject | Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support | From | Bart Van Assche <> | Date | Mon, 3 Feb 2020 14:30:37 -0800 |
| |
On 2/2/20 11:16 PM, Can Guo wrote: > On 2020-01-26 11:34, Bart Van Assche wrote: >> On 2020-01-22 23:25, Can Guo wrote: >>> + /* getting Specification Version in big endian format */ >>> + hba->dev_info.spec_version = >>> desc_buf[DEVICE_DESC_PARAM_SPEC_VER] << 8 | >>> + desc_buf[DEVICE_DESC_PARAM_SPEC_VER + 1]; >> >> Please use get_unaligned_be16() instead of open-coding it. > > I am just keeping symmetry with the other device descriptors, > for example w_manufacturer_id.
Hi Can,
How about adding an additional patch that refactors the existing code?
Please use get_unaligned_be16() in new code. That makes code easier to read compared to open-coding get_unaligned_be16().
Thanks,
Bart.
| |