Messages in this thread | | | Date | Sat, 29 Feb 2020 08:58:02 +0100 | From | Jiri Pirko <> | Subject | Re: [RFC net-next 2/3] net: marvell: prestera: Add PCI interface support |
| |
Fri, Feb 28, 2020 at 05:54:32PM CET, vadym.kochan@plvision.eu wrote: >Hi Jiri, > >On Thu, Feb 27, 2020 at 12:05:07PM +0100, Jiri Pirko wrote: >> Tue, Feb 25, 2020 at 05:30:55PM CET, vadym.kochan@plvision.eu wrote: >> >Add PCI interface driver for Prestera Switch ASICs family devices, which >> >provides: >> > > >[SNIP] > >> >+ >> >+module_init(mvsw_pr_pci_init); >> >+module_exit(mvsw_pr_pci_exit); >> >+ >> >+MODULE_AUTHOR("Marvell Semi."); >> >> Again, wrong author. >> > >PLVision developing the driver for Marvell and upstreaming it on behalf >of Marvell. This is a long term cooperation that aim to expose Marvell >devices to the Linux community.
Okay. If you grep the code, most of the time, the MODULE_AUTHOR is a person. That was my point: /* * Author(s), use "Name <email>" or just "Name", for multiple * authors use multiple MODULE_AUTHOR() statements/lines. */ #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
But I see that for example "Intel" uses the company name too. So I guess it is fine.
> >[SNIP] > >Regards, >Vadym Kochan
| |