lkml.org 
[lkml]   [2020]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bitfield.h: add FIELD_MAX() and field_max()
On Fri, 28 Feb 2020 12:37:14 -0600 Alex Elder wrote:
> On 2/28/20 12:33 PM, Jakub Kicinski wrote:
> > On Fri, 28 Feb 2020 12:06:09 -0600 Alex Elder wrote:
> >> On 2/28/20 12:04 PM, Alex Elder wrote:
> >>>
> >>>
> >>> I find field_max() to be a good name for what I'm looking for.
> >>
> >> Sorry I wanted to add this but clicked "send" too fast.
> >>
> >> Yes it's the same as field_mask(), but that name only *implies*
> >> it is the same as the maximum value. I mean, they're the same,
> >> but the name I'm suggesting conveys its purpose better.
> >
> > We got FIELD_FIT tho.. The comparison is part of the macro there,
> > and it catches negative values if they manage to sneak in.
>
> Ahhh! I was using the lower-case macros and it looks like there
> isn't one (despite seeming to have all(?) of the others).

Ah, damn, I didn't check for the lower case version.

> How would you feel about having field_fit() be a lower-case
> equivalent of FIELD_FIT()?

That'd be great!

\
 
 \ /
  Last update: 2020-02-28 20:04    [W:0.123 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site