Messages in this thread | | | From | "Huang\, Ying" <> | Subject | Re: [RFC 2/3] mm: Add a new page flag PageLayzyFree() for MADV_FREE | Date | Fri, 28 Feb 2020 14:47:57 +0800 |
| |
David Hildenbrand <david@redhat.com> writes:
>> Am 28.02.2020 um 04:38 schrieb Huang, Ying <ying.huang@intel.com>: >> >> From: Huang Ying <ying.huang@intel.com> >> >> Now !PageSwapBacked() is used as the flag for the pages freed lazily >> via MADV_FREE. This isn't obvious enough. So Dave suggested to add a >> new page flag for that to improve the code readability. > > This patch subject and description is *really* confusing. You‘re adding a helper function, not a page flag. It‘s a fairly easy refactoring.
Yes. Thanks for reminding. I will revise this in the next version.
Best Regards, Huang, Ying
> (Adding new page flags is close to impossible). > > Cheers!
| |