| Subject | Re: [PATCH v3 25/27] powerpc/powernv/pmem: Expose the serial number in sysfs | From | Andrew Donnellan <> | Date | Fri, 28 Feb 2020 17:25:31 +1100 |
| |
On 21/2/20 2:27 pm, Alastair D'Silva wrote: > +int ocxlpmem_sysfs_add(struct ocxlpmem *ocxlpmem) > +{ > + int i, rc; > + > + for (i = 0; i < ARRAY_SIZE(attrs); i++) { > + rc = device_create_file(&ocxlpmem->dev, &attrs[i]); > + if (rc) { > + for (; --i >= 0;) > + device_remove_file(&ocxlpmem->dev, &attrs[i]);
I'd rather avoid weird for loop constructs if possible.
Is it actually dangerous to call device_remove_file() on an attr that hasn't been added? If not then I'd rather define an err: label and loop over the whole array there.
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited
|