lkml.org 
[lkml]   [2020]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 25/27] powerpc/powernv/pmem: Expose the serial number in sysfs
From
Date
On 21/2/20 2:27 pm, Alastair D'Silva wrote:
> +int ocxlpmem_sysfs_add(struct ocxlpmem *ocxlpmem)
> +{
> + int i, rc;
> +
> + for (i = 0; i < ARRAY_SIZE(attrs); i++) {
> + rc = device_create_file(&ocxlpmem->dev, &attrs[i]);
> + if (rc) {
> + for (; --i >= 0;)
> + device_remove_file(&ocxlpmem->dev, &attrs[i]);

I'd rather avoid weird for loop constructs if possible.

Is it actually dangerous to call device_remove_file() on an attr that
hasn't been added? If not then I'd rather define an err: label and loop
over the whole array there.

--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited

\
 
 \ /
  Last update: 2020-02-28 07:27    [W:0.330 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site