lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 68/97] ext4: fix mount failure with quota configured as module
    Date
    From: Jan Kara <jack@suse.cz>

    commit 9db176bceb5c5df4990486709da386edadc6bd1d upstream.

    When CONFIG_QFMT_V2 is configured as a module, the test in
    ext4_feature_set_ok() fails and so mount of filesystems with quota or
    project features fails. Fix the test to use IS_ENABLED macro which
    works properly even for modules.

    Link: https://lore.kernel.org/r/20200221100835.9332-1-jack@suse.cz
    Fixes: d65d87a07476 ("ext4: improve explanation of a mount failure caused by a misconfigured kernel")
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/super.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -2948,7 +2948,7 @@ static int ext4_feature_set_ok(struct su
    return 0;
    }

    -#if !defined(CONFIG_QUOTA) || !defined(CONFIG_QFMT_V2)
    +#if !IS_ENABLED(CONFIG_QUOTA) || !IS_ENABLED(CONFIG_QFMT_V2)
    if (!readonly && (ext4_has_feature_quota(sb) ||
    ext4_has_feature_project(sb))) {
    ext4_msg(sb, KERN_ERR,

    \
     
     \ /
      Last update: 2020-02-27 15:07    [W:3.040 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site