lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 055/237] MIPS: Loongson: Fix potential NULL dereference in loongson3_platform_init()
    Date
    From: Tiezhu Yang <yangtiezhu@loongson.cn>

    [ Upstream commit 72d052e28d1d2363f9107be63ef3a3afdea6143c ]

    If kzalloc fails, it should return -ENOMEM, otherwise may trigger a NULL
    pointer dereference.

    Fixes: 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface")
    Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
    Signed-off-by: Paul Burton <paulburton@kernel.org>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: Huacai Chen <chenhc@lemote.com>
    Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
    Cc: linux-mips@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/loongson64/loongson-3/platform.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/arch/mips/loongson64/loongson-3/platform.c b/arch/mips/loongson64/loongson-3/platform.c
    index 25a97cc0ee336..0db4cc3196ebd 100644
    --- a/arch/mips/loongson64/loongson-3/platform.c
    +++ b/arch/mips/loongson64/loongson-3/platform.c
    @@ -31,6 +31,9 @@ static int __init loongson3_platform_init(void)
    continue;

    pdev = kzalloc(sizeof(struct platform_device), GFP_KERNEL);
    + if (!pdev)
    + return -ENOMEM;
    +
    pdev->name = loongson_sysconf.sensors[i].name;
    pdev->id = loongson_sysconf.sensors[i].id;
    pdev->dev.platform_data = &loongson_sysconf.sensors[i];
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-02-27 14:55    [W:4.334 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site