Messages in this thread | | | Subject | Re: [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA | From | Lukasz Luba <> | Date | Thu, 27 Feb 2020 12:08:46 +0000 |
| |
Hi Valentin,
On 2/27/20 11:04 AM, Valentin Schneider wrote: > Hi Lukasz, > > On 2/27/20 11:00 AM, Lukasz Luba wrote: >> Fix kernel build warning in kernel/sched/fair.c when CONFIG_SCHED_SMT is >> not set and CONFIG_NUMA_BALANCING is set. >> >> kernel/sched/fair.c:1524:20: warning: ‘test_idle_cores’ declared ‘static’ but never defined [-Wunused-function] >> > > I've sent a similar fix yesterday at: > > https://lore.kernel.org/lkml/20200226121244.7524-1-valentin.schneider@arm.com/ >
I've missed it. You are referring in the commit message to wrong change (probably HEAD of that branch), while when you try to bisect, it will point you to ff7db0bf24db sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks
I think Mel can simply resend the patches with correct build if Ingo is OK.
If Mel would decide to go with extended approach of ifdefs, then maybe it's also good to put in there numa_idle_core(), which actually uses these test_idle_cores() and is_core_idle()
Regards, Lukasz
| |