Messages in this thread | | | Date | Thu, 27 Feb 2020 17:01:49 +0100 | From | Antoine Tenart <> | Subject | Re: [PATCH net-next 3/3] net: phy: mscc: implement RGMII skew delay configuration |
| |
Hello Andrew,
On Thu, Feb 27, 2020 at 04:51:28PM +0100, Andrew Lunn wrote: > On Thu, Feb 27, 2020 at 04:28:59PM +0100, Antoine Tenart wrote: > > This patch adds support for configuring the RGMII skews in Rx and Tx > > thanks to properties defined in the device tree. > > Hi Antoine > > What you are not handling here in this patchset is the four RGMII > modes, and what they mean in terms of delay: > > PHY_INTERFACE_MODE_RGMII, > PHY_INTERFACE_MODE_RGMII_ID, > PHY_INTERFACE_MODE_RGMII_RXID, > PHY_INTERFACE_MODE_RGMII_TXID, > > The PHY driver should be adding delays based on these > values. Generally, that is enough to make the link work. You only need > additional skew in DT when you need finer grain control than what > these provide.
Oh, that's right. I'll fix the series and resubmit.
Thanks! Antoine
-- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |