lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 2/6] Bindings: nvmem: add bindings for JZ4780 efuse
    Hi Nikolaus,


    Le mer., févr. 26, 2020 at 12:15, H. Nikolaus Schaller
    <hns@goldelico.com> a écrit :
    > From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
    >
    > This patch brings support for the JZ4780 efuse. Currently it only
    > exposes
    > a read only access to the entire 8K bits efuse memory.
    >
    > Tested-by: Mathieu Malaterre <malat@debian.org>
    > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
    > Signed-off-by: Mathieu Malaterre <malat@debian.org>
    > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
    > [converted to yaml]
    > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
    > ---
    > .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 50
    > +++++++++++++++++++
    > 1 file changed, 50 insertions(+)
    > create mode 100644
    > Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
    >
    > diff --git
    > a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
    > b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
    > new file mode 100644
    > index 000000000000..b9c0ea09b335
    > --- /dev/null
    > +++
    > b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
    > @@ -0,0 +1,50 @@
    > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Ingenic JZ EFUSE driver bindings
    > +
    > +maintainers:
    > + - PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
    > +
    > +allOf:
    > + - $ref: "nvmem.yaml#"
    > +
    > +properties:
    > + compatible:
    > + enum:
    > + - ingenic,jz4780-efuse
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + clocks:
    > + # Handle for the ahb for the efuse.
    > + maxItems: 1
    > +
    > + clock-names:
    > + items:
    > + - const: ahb2

    Your driver does not actually require the clock to be 'ahb2', it will
    take the first clock independently of its name. So 'clock-names' can be
    dropped.

    > +
    > +required:
    > + - compatible
    > + - reg
    > + - clocks
    > +
    > +unevaluatedProperties: false
    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/clock/jz4780-cgu.h>
    > +
    > + efuse@134100d0 {
    > + compatible = "ingenic,jz4780-efuse";
    > + reg = <0x134100d0 0x2c>;
    > +
    > + clocks = <&cgu JZ4780_CLK_AHB2>;
    > + clock-names = "ahb2";

    Same here.

    Cheers,
    -Paul

    > + };
    > +
    > +...
    > --
    > 2.23.0
    >


    \
     
     \ /
      Last update: 2020-02-27 15:49    [W:3.915 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site