lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 131/237] pwm: Remove set but not set variable pwm
    Date
    From: yu kuai <yukuai3@huawei.com>

    [ Upstream commit 9871abffc81048e20f02e15d6aa4558a44ad53ea ]

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/pwm/pwm-pca9685.c: In function ‘pca9685_pwm_gpio_free’:
    drivers/pwm/pwm-pca9685.c:162:21: warning: variable ‘pwm’ set but not used [-Wunused-but-set-variable]

    It is never used, and so can be removed. In that case, hold and release
    the lock 'pca->lock' can be removed since nothing will be done between
    them.

    Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")
    Signed-off-by: yu kuai <yukuai3@huawei.com>
    Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pwm/pwm-pca9685.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
    index 567f5e2771c47..e1e5dfcb16f36 100644
    --- a/drivers/pwm/pwm-pca9685.c
    +++ b/drivers/pwm/pwm-pca9685.c
    @@ -170,13 +170,9 @@ static void pca9685_pwm_gpio_set(struct gpio_chip *gpio, unsigned int offset,
    static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset)
    {
    struct pca9685 *pca = gpiochip_get_data(gpio);
    - struct pwm_device *pwm;

    pca9685_pwm_gpio_set(gpio, offset, 0);
    pm_runtime_put(pca->chip.dev);
    - mutex_lock(&pca->lock);
    - pwm = &pca->chip.pwms[offset];
    - mutex_unlock(&pca->lock);
    }

    static int pca9685_pwm_gpio_get_direction(struct gpio_chip *chip,
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-02-27 15:37    [W:4.046 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site