lkml.org 
[lkml]   [2020]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS SYSC type
* Suman Anna <s-anna@ti.com> [200226 16:39]:
> Hi Roger,
>
> On 2/26/20 2:42 AM, Roger Quadros wrote:
> > Hi Suman,
> >
> > On 25/02/2020 22:46, Suman Anna wrote:
> >> From: Roger Quadros <rogerq@ti.com>
> >>
> >> The PRUSS module has a SYSCFG which is unique. The SYSCFG
> >> has two additional unique fields called STANDBY_INIT and
> >> SUB_MWAIT in addition to regular IDLE_MODE and STANDBY_MODE
> >> fields. Add the bindings for this new sysc type.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >> Signed-off-by: Suman Anna <s-anna@ti.com>
> >> ---
> >>   Documentation/devicetree/bindings/bus/ti-sysc.txt | 1 +
> >>   include/dt-bindings/bus/ti-sysc.h                 | 4 ++++
> >>   2 files changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> index 233eb8294204..c984143d08d2 100644
> >> --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> @@ -38,6 +38,7 @@ Required standard properties:
> >>           "ti,sysc-dra7-mcasp"
> >>           "ti,sysc-usb-host-fs"
> >>           "ti,sysc-dra7-mcan"
> >> +        "ti,sysc-pruss"
> >>     - reg        shall have register areas implemented for the
> >> interconnect
> >>           target module in question such as revision, sysc and syss
> >> diff --git a/include/dt-bindings/bus/ti-sysc.h
> >> b/include/dt-bindings/bus/ti-sysc.h
> >
> > Did you intentionally leave this here? It should be part of 2nd patch?
>
> No, not really, include/bindings are also considered part of bindings.
> This patch alone should be enough for you to add the DT nodes.

Well I don't care either way, sort of would prefer to have this
with the device patch in case somebody starts back porting
driver changes.

Anyways, let's wayt for Rob's ack on this, maybe he has also
preference on the ti-sysc.h changes.

Regards,

Tony

\
 
 \ /
  Last update: 2020-02-26 19:33    [W:0.060 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site