Messages in this thread | | | Date | Wed, 26 Feb 2020 16:42:05 +0100 | From | Michael Walle <> | Subject | Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes |
| |
Am 2020-02-24 10:22, schrieb Z.q. Hou: > Hi Michael and Shawn, > > I'll update the patch with iommu-map property.
friendly ping :)
-michael
> > Thanks, > Zhiqiang > >> -----Original Message----- >> From: Michael Walle <michael@walle.cc> >> Sent: 2020年2月24日 16:54 >> To: Shawn Guo <shawnguo@kernel.org> >> Cc: Xiaowei Bao <xiaowei.bao@nxp.com>; Z.q. Hou >> <zhiqiang.hou@nxp.com>; bhelgaas@google.com; >> devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >> linux-pci@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; >> lorenzo.pieralisi@arm.com; mark.rutland@arm.com; M.h. Lian >> <minghuan.lian@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>; >> robh+dt@kernel.org; Roy Zang <roy.zang@nxp.com> >> Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller >> DT >> nodes >> >> Hi Shawn, all, >> >> Am 2020-02-24 09:43, schrieb Shawn Guo: >> > On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: >> >> Hi Xiaowei, Hi Shawn, >> >> >> >> > LS1028a implements 2 PCIe 3.0 controllers. >> >> >> >> Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about >> >> this patch anymore :( >> >> >> >> This doesn't work well with the IOMMU, because the iommu-map property >> >> is missing. The bootloader needs the &smmu phandle to fixup the >> >> entry. >> >> See >> >> below. >> >> >> >> Shawn, will you add this patch to your tree once its fixed, >> >> considering it just adds the device tree node for the LS1028A? >> > >> > The patch/thread is a bit aged. You may want to send an updated patch >> > for discussion. >> >> So should I just pick up the patch add my two fixes and send it again? >> What about >> the Signed-off-by tags? Leave them? Replace them? Add mine? >> >> -michael
| |