Messages in this thread | | | Subject | Re: [PATCH bpf-next v3 2/5] bpftool: Make probes which emit dmesg warnings optional | From | Daniel Borkmann <> | Date | Wed, 26 Feb 2020 16:35:18 +0100 |
| |
On 2/25/20 8:44 PM, Michal Rostecki wrote: > Probes related to bpf_probe_write_user and bpf_trace_printk helpers emit > dmesg warnings which might be confusing for people running bpftool on > production environments. This change filters them out by default and > introduces the new positional argument "full" which enables all > available probes. > > Signed-off-by: Michal Rostecki <mrostecki@opensuse.org> [...] > + /* Skip helper functions which emit dmesg messages when not in > + * the full mode. > + */ > + switch (id) { > + case 6: /* trace_printk */ > + case 36: /* probe_write_user */
Please fix this into the actual enum above, then also the comment is not needed.
> + if (!full_mode) > + continue; > + /* fallthrough */ > + default: > + probe_helper_for_progtype(prog_type, supported_type, > + define_prefix, id, ptype_name, > + ifindex); > } > }
| |