Messages in this thread | | | Date | Wed, 26 Feb 2020 14:06:44 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 0/3] SoundWire: ASoC interfaces for multi-cpu dais and DisCo helpers |
| |
On 25-02-20, 11:00, Pierre-Louis Bossart wrote: > The first two patches prepare the support of multi-cpu dais for > synchronized playback and capture. We remove an unused set of
Can you explain how this set does that..?
> prototypes and add a get_sdw_stream() callback prototype currently
Right, how does something which is unused and getting removed help in supporting multi-cpu dais?
> missing (the implementation will come later as part of the > synchronized playback)
I guess Mark can comment on this but we really want to see users of APIs as well.
> The last exposes macros used internally, so that they can be reused to > extract information from the _ADR 64-bit values in SOF platform > drivers and related machine drivers.
On it is own, i think 1st and last patch look fine to me, so I guess I will go ahead and apply them. I can understand that last one can be used by SOF driver so can be pulled by Mark, will put on topic branch..
> I think it's simpler if all these simple patches are merged through > the SoundWire tree. With the additional changes to remove the platform > drivers and the merge of interrupt handling, that will result in a > single immutable tag provided to Mark Brown. > > Pierre-Louis Bossart (3): > soundwire: cadence: remove useless prototypes > ASoC: soc-dai: add get_sdw_stream() callback > soundwire: add helper macros for devID fields > > drivers/soundwire/bus.c | 21 +++++---------------- > drivers/soundwire/cadence_master.h | 8 -------- > include/linux/soundwire/sdw.h | 23 +++++++++++++++++++++++ > include/sound/soc-dai.h | 21 +++++++++++++++++++++ > 4 files changed, 49 insertions(+), 24 deletions(-) > > -- > 2.20.1
-- ~Vinod
| |