Messages in this thread | | | Subject | Re: [for-next PATCH 1/5] phy: ti: gmii-sel: simplify config dependencies between net drivers and gmii phy | From | Murali Karicheri <> | Date | Tue, 25 Feb 2020 13:04:34 -0500 |
| |
Hi Grygorii,
On 02/22/2020 07:03 AM, Grygorii Strashko wrote: > The phy-gmii-sel can be only autoselacted in Kconfig and now the pretty s/autoselacted/auto selected > complex Kconfig dependencies are defined for phy-gmii-sel driver, which > also need to be updated every time phy-gmii-sel is re-used for any new > networking driver. > > Simplify Kconfig definotion for phy-gmii-sel PHY driver - drop all
s/definotion/definition
> depndencies and from networking drivers and rely on using 'imply imply
s/depndencies/dependencies
> PHY_TI_GMII_SEL' in Kconfig definotions for networking drivers instead. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/net/ethernet/ti/Kconfig | 1 + > drivers/phy/ti/Kconfig | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig > index bf98e0fa7d8b..8a6ca16eee3b 100644 > --- a/drivers/net/ethernet/ti/Kconfig > +++ b/drivers/net/ethernet/ti/Kconfig > @@ -53,6 +53,7 @@ config TI_CPSW > select MFD_SYSCON > select PAGE_POOL > select REGMAP > + imply PHY_TI_GMII_SEL > ---help--- > This driver supports TI's CPSW Ethernet Switch. > > diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig > index 6dbe9d0b9ff3..15a3bcf32308 100644 > --- a/drivers/phy/ti/Kconfig > +++ b/drivers/phy/ti/Kconfig > @@ -106,11 +106,8 @@ config TWL4030_USB > > config PHY_TI_GMII_SEL > tristate > - default y if TI_CPSW=y || TI_CPSW_SWITCHDEV=y > - depends on TI_CPSW || TI_CPSW_SWITCHDEV || COMPILE_TEST > select GENERIC_PHY > select REGMAP > - default m > help > This driver supports configuring of the TI CPSW Port mode depending on > the Ethernet PHY connected to the CPSW Port. >
-- Murali Karicheri Texas Instruments
| |