lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
    On Fri, Feb 07, 2020 at 01:26:21PM +0800, Nicolas Boichat wrote:
    > Define a compatible string for the Mali Bifrost GPU found in
    > Mediatek's MT8183 SoCs.
    >
    > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
    > Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
    > ---
    >
    > v4:
    > - Add power-domain-names description
    > (kept Alyssa's reviewed-by as the change is minor)
    > v3:
    > - No change
    >
    > .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++++++++++++++++
    > 1 file changed, 25 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
    > index 4ea6a8789699709..0d93b3981445977 100644
    > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
    > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
    > @@ -17,6 +17,7 @@ properties:
    > items:
    > - enum:
    > - amlogic,meson-g12a-mali
    > + - mediatek,mt8183-mali
    > - realtek,rtd1619-mali
    > - rockchip,px30-mali
    > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
    > @@ -62,6 +63,30 @@ allOf:
    > minItems: 2
    > required:
    > - resets
    > + - if:
    > + properties:
    > + compatible:
    > + contains:
    > + const: mediatek,mt8183-mali
    > + then:
    > + properties:
    > + sram-supply: true
    > + power-domains:
    > + description:
    > + List of phandle and PM domain specifier as documented in
    > + Documentation/devicetree/bindings/power/power_domain.txt
    > + minItems: 3
    > + maxItems: 3
    > + power-domain-names:
    > + items:
    > + - const: core0
    > + - const: core1
    > + - const: 2d

    AFAIK, there's no '2d' block in bifrost GPUs. A power domain for each
    core group is correct though.

    Rob

    \
     
     \ /
      Last update: 2020-02-25 18:17    [W:3.701 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site