lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v7 2/2] Documentation: devictree: Add ipq806x mdio bindings
On Mon, Feb 24, 2020 at 3:10 PM Ansuel Smith <ansuelsmth@gmail.com> wrote:
>

typo in the subject. Use 'dt-bindings: net: ...' for the subject prefix.

> Add documentations for ipq806x mdio driver.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> Changes in v7:
> - Fix dt_binding_check problem

Um, no you didn't...

>
> .../bindings/net/qcom,ipq8064-mdio.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
> new file mode 100644
> index 000000000000..3178cbfdc661
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/qcom,ipq8064-mdio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm ipq806x MDIO bus controller
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +description: |+

Don't need '|+' unless you need specific formatting.

> + The ipq806x soc have a MDIO dedicated controller that is
> + used to comunicate with the gmac phy conntected.
> + Child nodes of this MDIO bus controller node are standard
> + Ethernet PHY device nodes as described in
> + Documentation/devicetree/bindings/net/phy.txt
> +
> +allOf:
> + - $ref: "mdio.yaml#"
> +
> +properties:
> + compatible:
> + const: qcom,ipq8064-mdio

blank line between properties please.

> + reg:
> + maxItems: 1
> + description: address and length of the register set for the device

That's every 'reg', you can drop this.

> + clocks:
> + maxItems: 1
> + description: A reference to the clock supplying the MDIO bus controller

That's every 'clocks', you can drop this.

> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - "#address-cells"
> + - "#size-cells"
> +
> +examples:
> + - |
> + mdio0: mdio@37000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + compatible = "qcom,ipq8064-mdio", "syscon";

'syscon' doesn't match the schema and is wrong.

> + reg = <0x37000000 0x200000>;

> + resets = <&gcc GMAC_CORE1_RESET>;
> + reset-names = "stmmaceth";

Not documented.

> + clocks = <&gcc GMAC_CORE1_CLK>;

You need to include the header for these defines.

> +
> + switch@10 {
> + compatible = "qca,qca8337";
> + /* ... */
> + };
> + };
> --
> 2.25.0
>

\
 
 \ /
  Last update: 2020-02-25 17:58    [W:0.074 / U:2.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site