lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check()
On Sun, Feb 23, 2020 at 11:16:44PM +0000, Jules Irenge wrote:
> Sparse reports a warning at xfs_ail_check()
>
> warning: context imbalance in xfs_ail_check() - unexpected unlock
>
> The root cause is the missing annotation at xfs_ail_check()
>
> Add the missing __must_hold(&ailp->ail_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Seems reasonable, though I'm wondering if this is a treewide change you
seek to apply yourself, or merely a large patch series to merge through
the individual subsystem maintainers?

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/xfs_trans_ail.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 00cc5b8734be..58d4ef1b4c05 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -32,6 +32,7 @@ STATIC void
> xfs_ail_check(
> struct xfs_ail *ailp,
> struct xfs_log_item *lip)
> + __must_hold(&ailp->ail_lock)
> {
> struct xfs_log_item *prev_lip;
> struct xfs_log_item *next_lip;
> --
> 2.24.1
>

\
 
 \ /
  Last update: 2020-02-25 16:44    [W:0.340 / U:3.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site