lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem_config
    Date
    On Mon, Feb 24, 2020 at 05:43:29PM +0000, Nicholas Johnson wrote:
    > There is no .write_only field in nvmem_config, so having .read_only
    > makes no sense. We can determine the attrs based on whether .reg_read
    > and .reg_write are provided. Using only .reg_read and .reg_write means
    > that there can no longer be contradictions (for instance, if .read_only
    > is set but .reg_read is NULL).
    >
    > Remove .read_only field from nvmem_config.
    >
    > Remove all references to .read_only field from drivers.
    >
    > Update drivers to only supply nvmem->reg_write if write attrs are
    > desired.
    >
    > Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
    > ---

    Sorry all, I got this build bot [0] telling me that this patch 3/3 fails
    to compile for ARM architecture. It worked for x86-64. So please ignore
    3/3 for now while I investigate. 1/3 and 2/3 are all good.

    I will find a better way to ensure that I have all of the references and
    post a PATCH v2 sometime.

    Kind regards,
    Nicholas

    [0]
    https://lore.kernel.org/lkml/202002250920.gc0wDekv%25lkp@intel.com/

    \
     
     \ /
      Last update: 2020-02-25 11:51    [W:4.189 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site