Messages in this thread | | | From | Schrempf Frieder <> | Subject | Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 | Date | Tue, 25 Feb 2020 08:03:25 +0000 |
| |
On 25.02.20 07:12, Vinod Koul wrote: > On 24-02-20, 15:43, Fabio Estevam wrote: >> Hi Frieder, >> >> On Mon, Feb 24, 2020 at 2:22 PM Schrempf Frieder >> <frieder.schrempf@kontron.de> wrote: >>> >>> From: Frieder Schrempf <frieder.schrempf@kontron.de> >>> >>> On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix >> >> I would suggest being a bit more specific than saying i.MX6. >> >> I see UART6 is present on i.MX6UL/i.MX6SX, but not on i.MX6Q/i.MX6DL, >> so it would be better to specify it in the commit log. >> >> imx6ul.dtsi does not have dma nodes under uart6, so I guess you fixed >> it for imx6sx. > > and use right subsystem tag dmaengine. Git log of the file should tell > you the right one to use :)
Sorry, my bad. I will fix it.
> >> >>> the broken DMA support for UART6, we change the check for event_id0 >>> to include '0' as a valid id. >>> >>> Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> Reviewed-by: Fabio Estevam <festevam@gmail.com> > | |