Messages in this thread | | | From | Song Liu <> | Date | Tue, 25 Feb 2020 14:56:00 -0800 | Subject | Re: [PATCH v3 bpf-next] RV32G eBPF JIT |
| |
On Tue, Feb 25, 2020 at 10:37 AM Luke Nelson <lukenels@cs.washington.edu> wrote: > > > > I found a lot of common code between RV32G and RV64G. Can we move > > these code into a header file? > > Certainly! I was planning on doing this in a separate patch to minimize the changes > to the RV64 JIT. I can also do it in another revision of this patch if that seems like a better idea.
I would recommend expand this patch into two patches: one patch moves common code to a header, the other adds logic for RV32G.
Thanks, Song
| |