lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 5/9] net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver
From
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Sat, 22 Feb 2020 17:57:48 +0200

> +/**
> + * struct am65_cpsw_regdump_hdr - regdump record header
> + *
> + * @module_id: CPSW module ID
> + * @len: CPSW module registers space length in u32
> + */
> +
> +struct am65_cpsw_regdump_hdr {
> + u32 module_id;
> + u32 len;
> +} __packed;

I see no reason for this __packed attribute, please remove it.

> +void am65_cpsw_nuss_adjust_link(struct net_device *ndev)
> +{
> + struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
> + struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> + struct phy_device *phy = port->slave.phy;
> + u32 mac_control = 0;

Please order the local variables in reverse christmas tree order,
thank you.

> +static void am65_cpsw_nuss_ndo_slave_set_rx_mode(struct net_device *ndev)
> +{
> + struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
> + struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> + u32 port_mask;
> + bool promisc;

Likewise.

> +static int am65_cpsw_nuss_rx_push(struct am65_cpsw_common *common,
> + struct sk_buff *skb)
> +{
> + struct cppi5_host_desc_t *desc_rx;
> + struct am65_cpsw_rx_chn *rx_chn = &common->rx_chns;
> + struct device *dev = common->dev;
> + dma_addr_t desc_dma;
> + dma_addr_t buf_dma;
> + u32 pkt_len = skb_tailroom(skb);
> + void *swdata;

Likewsie.

And so on, and so forth, for your entire submission.

Thank you.

\
 
 \ /
  Last update: 2020-02-24 06:07    [W:0.172 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site