lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: qlge: add braces around macro arguments
On 2020/02/22 01:26 +0530, Kaaira Gupta wrote:
> Fix checkpatch.pl warnings of adding braces around macro arguments to
> prevent precedence issues by adding braces in qlge_dbg.c
>
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
> drivers/staging/qlge/qlge_dbg.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 8cf39615c520..c7af2548d119 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -1525,7 +1525,7 @@ void ql_dump_regs(struct ql_adapter *qdev)
> #ifdef QL_STAT_DUMP
>
> #define DUMP_STAT(qdev, stat) \
> - pr_err("%s = %ld\n", #stat, (unsigned long)qdev->nic_stats.stat)
> + pr_err("%s = %ld\n", #stat, (unsigned long)(qdev)->nic_stats.stat)
>
> void ql_dump_stat(struct ql_adapter *qdev)
> {
> @@ -1578,12 +1578,12 @@ void ql_dump_stat(struct ql_adapter *qdev)
> #ifdef QL_DEV_DUMP
>
> #define DUMP_QDEV_FIELD(qdev, type, field) \
> - pr_err("qdev->%-24s = " type "\n", #field, qdev->field)
> + pr_err("qdev->%-24s = " type "\n", #field, (qdev)->(field))
> #define DUMP_QDEV_DMA_FIELD(qdev, field) \
> pr_err("qdev->%-24s = %llx\n", #field, (unsigned long long)qdev->field)
^^^^
You missed one.

\
 
 \ /
  Last update: 2020-02-24 06:32    [W:0.069 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site