lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next v1 15/18] net/apm: Properly mark absence of FW
    Date
    From: Leon Romanovsky <leonro@mellanox.com>

    There is no need to set "N/A" if FW is not available.

    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    ---
    drivers/net/ethernet/apm/xgene-v2/ethtool.c | 1 -
    drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c | 1 -
    2 files changed, 2 deletions(-)

    diff --git a/drivers/net/ethernet/apm/xgene-v2/ethtool.c b/drivers/net/ethernet/apm/xgene-v2/ethtool.c
    index da748beb7047..b78d1a99fe81 100644
    --- a/drivers/net/ethernet/apm/xgene-v2/ethtool.c
    +++ b/drivers/net/ethernet/apm/xgene-v2/ethtool.c
    @@ -89,7 +89,6 @@ static void xge_get_drvinfo(struct net_device *ndev,
    struct platform_device *pdev = pdata->pdev;

    strcpy(info->driver, "xgene-enet-v2");
    - snprintf(info->fw_version, ETHTOOL_FWVERS_LEN, "N/A");
    sprintf(info->bus_info, "%s", pdev->name);
    }

    diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c b/drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c
    index 4e7a95bd83d7..ada70425b48c 100644
    --- a/drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c
    +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c
    @@ -103,7 +103,6 @@ static void xgene_get_drvinfo(struct net_device *ndev,
    struct platform_device *pdev = pdata->pdev;

    strcpy(info->driver, "xgene_enet");
    - snprintf(info->fw_version, ETHTOOL_FWVERS_LEN, "N/A");
    sprintf(info->bus_info, "%s", pdev->name);
    }

    --
    2.24.1
    \
     
     \ /
      Last update: 2020-02-24 09:56    [W:2.567 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site