lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/10] floppy: cleanup: expand macro FDCS
Date
Hi,

On 2/25/20 12:53 AM, Linus Torvalds wrote:
> So I'd like to see that second step that does the
>
> -static int fdc; /* current fdc */
> +static int current_fdc;
>
> change.
>
> We already call the global 'drive' variable 'current_drive', so it
> really is 'fdc' that is misnamed and ambiguous because it then has two
> different cases: the global 'fdc' and then the various shadowing local
> 'fdc' variables (or function arguments).
>
> Mind adding that too? Slightly less automatic, I agree, because then
> you really do have to disambiguate between the "is this the shadowed
> use of a local 'fdc'" case or the "this is the global 'fdc' use" case.
>
> Can coccinelle do that?

Willy, if you don't want to spend your time with this code anymore I can
prepare patсhes for the second step. I know coccinelle and could try
to automate this transformation. At first sight your patches look
good to me. I will answer to the top email after more accurate review.

Thanks,
Denis

\
 
 \ /
  Last update: 2020-02-25 00:15    [W:0.081 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site