| Date | Mon, 24 Feb 2020 13:53:24 -0800 | From | Christoph Hellwig <> | Subject | Re: [Cluster-devel] [PATCH v7 12/24] mm: Add page_cache_readahead_unbounded |
| |
On Wed, Feb 19, 2020 at 01:00:51PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > ext4 and f2fs have duplicated the guts of the readahead code so > they can read past i_size. Instead, separate out the guts of the > readahead code so they can call it directly.
I don't like this, but then I like the horrible open coded versions even less.. Can you add a do not use for new code comment to the function as well?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
|