lkml.org 
[lkml]   [2020]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH] net: hns3: remove redundant initialization of pointer 'client'
From
From: Colin King <colin.king@canonical.com>
Date: Sat, 22 Feb 2020 19:52:31 +0000

> @@ -9076,7 +9076,7 @@ static int hclge_init_nic_client_instance(struct hnae3_ae_dev *ae_dev,
> static int hclge_init_roce_client_instance(struct hnae3_ae_dev *ae_dev,
> struct hclge_vport *vport)
> {
> - struct hnae3_client *client = vport->roce.client;
> + struct hnae3_client *client;
> struct hclge_dev *hdev = ae_dev->priv;
> int rst_cnt;
> int ret;

Please preserve the reverse christmas tree ordering of local variables when
you make changes like this.

\
 
 \ /
  Last update: 2020-02-24 02:28    [W:0.046 / U:27.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site