lkml.org 
[lkml]   [2020]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [net PATCH] hv_netvsc: Fix unwanted wakeup in netvsc_attach()
From
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 21 Feb 2020 08:32:18 -0800

> When netvsc_attach() is called by operations like changing MTU, etc.,
> an extra wakeup may happen while netvsc_attach() calling
> rndis_filter_device_add() which sends rndis messages when queue is
> stopped in netvsc_detach(). The completion message will wake up queue 0.
>
> We can reproduce the issue by changing MTU etc., then the wake_queue
> counter from "ethtool -S" will increase beyond stop_queue counter:
> stop_queue: 0
> wake_queue: 1
> The issue causes queue wake up, and counter increment, no other ill
> effects in current code. So we didn't see any network problem for now.
>
> To fix this, initialize tx_disable to true, and set it to false when
> the NIC is ready to be attached or registered.
>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Applied, thank you.

\
 
 \ /
  Last update: 2020-02-24 01:34    [W:0.027 / U:7.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site