Messages in this thread | | | Date | Sun, 23 Feb 2020 20:50:30 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 2/2] perf annotate: Support interactive annotation of code without symbols |
| |
On Sat, Feb 22, 2020 at 07:37:49AM +0800, Jin, Yao wrote: > > > On 2/21/2020 10:45 PM, Jiri Olsa wrote: > > On Fri, Feb 21, 2020 at 10:46:08AM +0800, Jin Yao wrote: > > > > SNIP > > > > > > > > Signed-off-by: Jin Yao <yao.jin@linux.intel.com> > > > --- > > > tools/perf/ui/browsers/hists.c | 51 +++++++++++++++++++++++++++++----- > > > tools/perf/util/annotate.h | 2 ++ > > > 2 files changed, 46 insertions(+), 7 deletions(-) > > > > > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > > > index f36dee499320..5144528b2931 100644 > > > --- a/tools/perf/ui/browsers/hists.c > > > +++ b/tools/perf/ui/browsers/hists.c > > > @@ -2465,13 +2465,47 @@ do_annotate(struct hist_browser *browser, struct popup_action *act) > > > return 0; > > > } > > > +static struct symbol *new_annotate_sym(u64 addr, struct map *map, > > > + struct annotation_options *opts) > > > +{ > > > + struct symbol *sym; > > > + struct annotated_source *src; > > > + char name[64]; > > > + > > > + snprintf(name, sizeof(name), "%-#.*lx", BITS_PER_LONG / 4, addr); > > > + > > > + sym = symbol__new(addr, > > > + opts->annotate_dummy_len ? > > > + opts->annotate_dummy_len : ANNOTATION_DUMMY_LEN, > > > > I can't see annotate_dummy_len being set anywhere.. > > > > Yes, annotate_dummy_len is not set in this patch. Currently we just use the > default value. While maybe in future we will provide a perf report option or > set it in perf config. Now I just leave an interface here.
if that's just 'maybe in future we will provide' then please keep just the ANNOTATION_DUMMY_LEN, the abandoned opts->annotate_dummy_len var is confusing
thanks, jirka
| |