Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 22 Feb 2020 18:22:43 -0800 | Subject | Re: [RFC][PATCH v2 22/34] merging pick_link() with get_link(), part 5 |
| |
Ok, one step back:
On Sat, Feb 22, 2020 at 5:22 PM Al Viro <viro@zeniv.linux.org.uk> wrote: > > + if (err > 0) > + return get_link(nd); > + else > + return ERR_PTR(err); > }
.. and two steps forward, as you then entirely remove the code I just complained about.
> - err = step_into(nd, flags, dentry, inode, seq); > - if (!err) > - return NULL; > - else if (err > 0) > - return get_link(nd); > - else > - return ERR_PTR(err); > + return step_into(nd, flags, dentry, inode, seq);
I'm waiting with bated breath if the next patch will then remove the new odd if-return-else thing. But I'm not going to peek, it's going to be a surprise.
Linus
| |