lkml.org 
[lkml]   [2020]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC][PATCH v2 09/34] do_last(): collapse the call of path_to_nameidata()
    Date
    From: Al Viro <viro@zeniv.linux.org.uk>

    ... and shift filling struct path to just before the call of
    handle_mounts(). All callers of handle_mounts() are
    immediately preceded by path->mnt = nd->path.mnt now.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    ---
    fs/namei.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/fs/namei.c b/fs/namei.c
    index 4946d006ba20..f26af0559abf 100644
    --- a/fs/namei.c
    +++ b/fs/namei.c
    @@ -3364,8 +3364,6 @@ static int do_last(struct nameidata *nd,
    error = PTR_ERR(dentry);
    goto out;
    }
    - path.mnt = nd->path.mnt;
    - path.dentry = dentry;

    if (file->f_mode & FMODE_OPENED) {
    if ((file->f_mode & FMODE_CREATED) ||
    @@ -3382,7 +3380,8 @@ static int do_last(struct nameidata *nd,
    open_flag &= ~O_TRUNC;
    will_truncate = false;
    acc_mode = 0;
    - path_to_nameidata(&path, nd);
    + dput(nd->path.dentry);
    + nd->path.dentry = dentry;
    goto finish_open_created;
    }

    @@ -3396,6 +3395,8 @@ static int do_last(struct nameidata *nd,
    got_write = false;
    }

    + path.mnt = nd->path.mnt;
    + path.dentry = dentry;
    error = handle_mounts(&path, nd, &inode, &seq);
    if (unlikely(error < 0))
    return error;
    --
    2.11.0
    \
     
     \ /
      Last update: 2020-02-23 02:20    [W:4.132 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site