lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 005/191] net/sched: matchall: add missing validation of TCA_MATCHALL_FLAGS
    Date
    From: Davide Caratti <dcaratti@redhat.com>

    [ Upstream commit 1afa3cc90f8fb745c777884d79eaa1001d6927a6 ]

    unlike other classifiers that can be offloaded (i.e. users can set flags
    like 'skip_hw' and 'skip_sw'), 'cls_matchall' doesn't validate the size
    of netlink attribute 'TCA_MATCHALL_FLAGS' provided by user: add a proper
    entry to mall_policy.

    Fixes: b87f7936a932 ("net/sched: Add match-all classifier hw offloading.")
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/cls_matchall.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/sched/cls_matchall.c
    +++ b/net/sched/cls_matchall.c
    @@ -137,6 +137,7 @@ static void *mall_get(struct tcf_proto *
    static const struct nla_policy mall_policy[TCA_MATCHALL_MAX + 1] = {
    [TCA_MATCHALL_UNSPEC] = { .type = NLA_UNSPEC },
    [TCA_MATCHALL_CLASSID] = { .type = NLA_U32 },
    + [TCA_MATCHALL_FLAGS] = { .type = NLA_U32 },
    };

    static int mall_set_parms(struct net *net, struct tcf_proto *tp,

    \
     
     \ /
      Last update: 2020-02-21 09:30    [W:4.017 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site