lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 006/191] net/sched: flower: add missing validation of TCA_FLOWER_FLAGS
    Date
    From: Davide Caratti <dcaratti@redhat.com>

    [ Upstream commit e2debf0852c4d66ba1a8bde12869b196094c70a7 ]

    unlike other classifiers that can be offloaded (i.e. users can set flags
    like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of
    netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry
    to fl_policy.

    Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support")
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/cls_flower.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/sched/cls_flower.c
    +++ b/net/sched/cls_flower.c
    @@ -486,6 +486,7 @@ static const struct nla_policy fl_policy
    [TCA_FLOWER_KEY_ENC_IP_TTL_MASK] = { .type = NLA_U8 },
    [TCA_FLOWER_KEY_ENC_OPTS] = { .type = NLA_NESTED },
    [TCA_FLOWER_KEY_ENC_OPTS_MASK] = { .type = NLA_NESTED },
    + [TCA_FLOWER_FLAGS] = { .type = NLA_U32 },
    };

    static const struct nla_policy

    \
     
     \ /
      Last update: 2020-02-21 09:19    [W:2.320 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site