Messages in this thread | | | Subject | Re: [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver | From | Dmitry Osipenko <> | Date | Fri, 21 Feb 2020 08:53:43 +0300 |
| |
20.02.2020 09:34, Sameer Pujar пишет: > The Digital MIC (DMIC) Controller is used to interface with Pulse Density > Modulation (PDM) input devices. The DMIC controller implements a converter > to convert PDM signals to Pulse Code Modulation (PCM) signals. From signal > flow perspective, the DMIC can be viewed as a PDM receiver. > > This patch registers DMIC component with ASoC framework. The component > driver exposes DAPM widgets, routes and kcontrols for the device. The DAI > driver exposes DMIC interfaces, which can be used to connect different > components in the ASoC layer. Makefile and Kconfig support is added to > allow to build the driver. The DMIC devices can be enabled in the DT via > "nvidia,tegra210-dmic" compatible string. This driver can be used for > Tegra186 and Tegra194 chips as well. > > Signed-off-by: Sameer Pujar <spujar@nvidia.com> > ---
...
> +static const struct of_device_id tegra210_dmic_of_match[] = { > + { .compatible = "nvidia,tegra210-dmic" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, tegra210_dmic_of_match);
I'd move the tegra210_dmic_of_match close to tegra210_dmic_driver's definition, like most of the other drivers do it.
...
> +static struct platform_driver tegra210_dmic_driver = { > + .driver = { > + .name = "tegra210-dmic", > + .of_match_table = tegra210_dmic_of_match, > + .pm = &tegra210_dmic_pm_ops, > + }, > + .probe = tegra210_dmic_probe, > + .remove = tegra210_dmic_remove, > +}; > +module_platform_driver(tegra210_dmic_driver)
Otherwise:
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
| |